Rule to check for unused arguments in methods #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Except I don't see the need for what is the purpose of that? |
|
Was just following what the existing code did if there was an exception in CFLint. I assumed it was so there's no bug output. |
|
I think if there is an exception in the plugin, we shouldn't wipe any other messages that are already reported. |
Conflicts: src/main/resources/cflint.definition.json src/main/resources/cflint.definition.xml
justinmclean
added a commit
that referenced
this pull request
Nov 8, 2015
Rule to check for unused arguments in methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you check the changes to
CFLint.java, all of the tests pass.